Inflection 134 Use std::unique_ptr to avoid delete #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grhoten
reviewed
Jul 15, 2025
| auto tokenizer = new Tokenizer(TOKENIZER_CONSTRUCTORS[mid].construct(locale, systemConfig)); | ||
| // Initialize the data loading and caches so that it doesn't possibly fail later. | ||
| delete npc(tokenizer)->createTokenChain(u"initialization"); | ||
| ::std::unique_ptr<TokenChain> unused(npc(tokenizer)->createTokenChain(u"initialization")); |
Member
There was a problem hiding this comment.
The original was actually correct. There is no intermediate line between getting the object and deleting it. I recommend leaving this one alone.
Collaborator
Author
There was a problem hiding this comment.
ok, I can take this out
Collaborator
Author
|
PTAL |
Member
|
I think the only remaining change needed is the Inflector.hpp change to make the destructor public is needed. |
Collaborator
Author
|
Changed according to comments. PTAL |
grhoten
approved these changes
Jul 22, 2025
deonajulary06
pushed a commit
that referenced
this pull request
Aug 21, 2025
* Use std::unique_ptr to avoid delete * Remove change to warm up code * Make destructor public instead of adding friend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#134